[PATCH] [core] add support to resolve section groups.
Rui Ueyama
ruiu at google.com
Tue Mar 25 13:51:20 PDT 2014
Additional minor comments.
================
Comment at: lib/Core/Resolver.cpp:216
@@ +215,3 @@
+ if (atom.contentType() == DefinedAtom::typeGroupComdat) {
+ bool isFirstTime = _symbolTable.addGroup(atom);
+ // Add all the group child members if the group is seen
----------------
Please make this piece of code a separate function ("maybeAddSectionGroup", maybe?) to keep the readability of this function.
================
Comment at: lib/Core/Resolver.cpp:230
@@ +229,3 @@
+ } // Iterate over references
+ } // isFirstTime
+ } else {
----------------
Remove comments from the above three lines. We don't usually add comments like them.
http://llvm-reviews.chandlerc.com/D3182
More information about the llvm-commits
mailing list