[llvm] r204579 - SupportTests.LockFileManagerTest: Add assertions for Win32.

Argyrios Kyrtzidis kyrtzidis at apple.com
Tue Mar 25 10:58:41 PDT 2014


Thank you!

On Mar 25, 2014, at 6:26 AM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:

> Should be fixed in r204719.
> 
> On 24 March 2014 18:40, Argyrios Kyrtzidis <kyrtzidis at apple.com> wrote:
>> 
>> On Mar 24, 2014, at 3:35 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>> 
>>> On 24 March 2014 18:32, Argyrios Kyrtzidis <kyrtzidis at apple.com> wrote:
>>>> 
>>>> On Mar 23, 2014, at 9:08 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>>>> 
>>>>> Argyrios, is this representative of how the lock manager is used? If
>>>>> so, it looks like it would not work on windows. If not, could you
>>>>> please update the test to avoid the ifdefs? For example, you could
>>>>> create the link to an existing file and then delete that file.
>>>> 
>>>> I’m fine with this change, but could someone with access to a windows machine test and commit this ?
>>> 
>>> You forgot to attach a patch?
>> 
>> No, I thought it was clear what you were suggesting.
>> 
>>> 
>>> Cheers,
>>> Rafael
>> 





More information about the llvm-commits mailing list