[llvm] r204672 - DebugInfo: Add DW_AT_GNU_ranges_base to skeleton CUs

[David Blaikie]

On Mon, Mar 24, 2014 at 2:58 PM, Eric Christopher <echristo at gmail.com> wrote:
>>
>>    // Relocate to the beginning of the addr_base section, else 0 for the
>>    // beginning of the one for this compile unit.
>> -  if (Asm->MAI->doesDwarfUseRelocationsAcrossSections())
>> +  // We could shave off some space if we deferred adding these attributes until
>> +  // the end of the CU to see if we have a non-empty debug_addr and debug_ranges
>> +  // sections so we don't bother with extra attributes and relocations.
>
> Could probably add this at the same place that I'm adding DW_AT_ranges
> to the skeleton CU.

Good point - implemented in r204702.

(might be nice to refactor that function (finalizeModuleInfo) into a
few more chunks - it starts off so well, with nice legible functions
for the different tasks, then we have some big chunks of nested loops,
etc - just breaking it up into smaller, named, functions might help
readability)

- David