[llvm] r204579 - SupportTests.LockFileManagerTest: Add assertions for Win32.

Rafael Espíndola rafael.espindola at gmail.com
Mon Mar 24 15:35:18 PDT 2014


On 24 March 2014 18:32, Argyrios Kyrtzidis <kyrtzidis at apple.com> wrote:
>
> On Mar 23, 2014, at 9:08 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>
>> Argyrios, is this representative of how the lock manager is used? If
>> so, it looks like it would not work on windows. If not, could you
>> please update the test to avoid the ifdefs? For example, you could
>> create the link to an existing file and then delete that file.
>
> I’m fine with this change, but could someone with access to a windows machine test and commit this ?

You forgot to attach a patch?

Cheers,
Rafael




More information about the llvm-commits mailing list