[llvm] r204496 - InstrProf: Read raw binary profile in llvm-profdata

Duncan P. N. Exon Smith dexonsmith at apple.com
Fri Mar 21 14:07:12 PDT 2014


On Mar 21, 2014, at 1:22 PM, Justin Bogner <mail at justinbogner.com> wrote:

> "Duncan P. N. Exon Smith" <dexonsmith at apple.com> writes:
>> InstrProf: Read raw binary profile in llvm-profdata
> 
>> +
>> +static uint64_t getRawVersion() {
>> +  return 1;
>> +}
>> +namespace {
>> +}
> 
> Looks like this empty namespace was left in by mistake.

Fixed this in a drive by (r204511) before I saw this.

>> +RawInstrProfReader::RawInstrProfReader(std::unique_ptr<MemoryBuffer> &DataBuffer)
>> +    : DataBuffer(DataBuffer.release()) { }
>> +
> 
> This is over 80-column. Might as well define this in the header anyway.

r204516



More information about the llvm-commits mailing list