[llvm] r204511 - InstrProf: Detect magic numbers in a more scalable way

[Duncan P. N. Exon Smith]

Author: dexonsmith
Date: Fri Mar 21 15:42:31 2014
New Revision: 204511

URL: http://llvm.org/viewvc/llvm-project?rev=204511&view=rev
Log:
InstrProf: Detect magic numbers in a more scalable way

No functionality change.

<rdar://problem/15950346>

Modified:
    llvm/trunk/include/llvm/ProfileData/InstrProfReader.h
    llvm/trunk/lib/ProfileData/InstrProfReader.cpp

Modified: llvm/trunk/include/llvm/ProfileData/InstrProfReader.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ProfileData/InstrProfReader.h?rev=204511&r1=204510&r2=204511&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ProfileData/InstrProfReader.h (original)
+++ llvm/trunk/include/llvm/ProfileData/InstrProfReader.h Fri Mar 21 15:42:31 2014
@@ -163,6 +163,7 @@ private:
 public:
   RawInstrProfReader(std::unique_ptr<MemoryBuffer> &DataBuffer);
 
+  static bool hasFormat(const MemoryBuffer &DataBuffer);
   error_code readHeader() override;
   error_code readNextRecord(InstrProfRecord &Record) override;
 

Modified: llvm/trunk/lib/ProfileData/InstrProfReader.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ProfileData/InstrProfReader.cpp?rev=204511&r1=204510&r2=204511&view=diff
==============================================================================
--- llvm/trunk/lib/ProfileData/InstrProfReader.cpp (original)
+++ llvm/trunk/lib/ProfileData/InstrProfReader.cpp Fri Mar 21 15:42:31 2014
@@ -19,18 +19,6 @@
 
 using namespace llvm;
 
-static uint64_t getRawMagic() {
-  return
-    uint64_t('l') << 56 |
-    uint64_t('p') << 48 |
-    uint64_t('r') << 40 |
-    uint64_t('o') << 32 |
-    uint64_t('f') << 24 |
-    uint64_t('r') << 16 |
-    uint64_t('a') <<  8 |
-    uint64_t('w');
-}
-
 error_code InstrProfReader::create(std::string Path,
                                    std::unique_ptr<InstrProfReader> &Result) {
   std::unique_ptr<MemoryBuffer> Buffer;
@@ -41,17 +29,13 @@ error_code InstrProfReader::create(std::
   if (Buffer->getBufferSize() > std::numeric_limits<unsigned>::max())
     return instrprof_error::too_large;
 
-  if (Buffer->getBufferSize() < sizeof(uint64_t)) {
-    Result.reset(new TextInstrProfReader(Buffer));
-    return Result->readHeader();
-  }
-
-  uint64_t Magic = *(uint64_t *)Buffer->getBufferStart();
-  uint64_t SwappedMagic = sys::SwapByteOrder(Magic);
-  if (Magic == getRawMagic() || SwappedMagic == getRawMagic())
+  // Create the reader.
+  if (RawInstrProfReader::hasFormat(*Buffer))
     Result.reset(new RawInstrProfReader(Buffer));
   else
     Result.reset(new TextInstrProfReader(Buffer));
+
+  // Read the header and return the result.
   return Result->readHeader();
 }
 
@@ -101,29 +85,43 @@ error_code TextInstrProfReader::readNext
   return success();
 }
 
-static uint64_t getRawVersion() {
-  return 1;
-}
-namespace {
-}
 RawInstrProfReader::RawInstrProfReader(std::unique_ptr<MemoryBuffer> &DataBuffer)
     : DataBuffer(DataBuffer.release()) { }
 
+static uint64_t getRawMagic() {
+  return
+    uint64_t('l') << 56 |
+    uint64_t('p') << 48 |
+    uint64_t('r') << 40 |
+    uint64_t('o') << 32 |
+    uint64_t('f') << 24 |
+    uint64_t('r') << 16 |
+    uint64_t('a') <<  8 |
+    uint64_t('w');
+}
+
+bool RawInstrProfReader::hasFormat(const MemoryBuffer &DataBuffer) {
+  if (DataBuffer.getBufferSize() < sizeof(getRawMagic()))
+    return false;
+  const RawHeader *Header = (const RawHeader *)DataBuffer.getBufferStart();
+  return getRawMagic() == Header->Magic ||
+    sys::SwapByteOrder(getRawMagic()) == Header->Magic;
+}
+
 error_code RawInstrProfReader::readHeader() {
+  if (!hasFormat(*DataBuffer))
+    return error(instrprof_error::bad_magic);
   if (DataBuffer->getBufferSize() < sizeof(RawHeader))
     return error(instrprof_error::bad_header);
-  const RawHeader *Header = (RawHeader *)DataBuffer->getBufferStart();
-  if (Header->Magic == getRawMagic())
-    ShouldSwapBytes = false;
-  else {
-    if (sys::SwapByteOrder(Header->Magic) != getRawMagic())
-      return error(instrprof_error::bad_magic);
-
-    ShouldSwapBytes = true;
-  }
+  const RawHeader *Header = (const RawHeader *)DataBuffer->getBufferStart();
+  ShouldSwapBytes = Header->Magic != getRawMagic();
   return readHeader(*Header);
 }
 
+static uint64_t getRawVersion() {
+  return 1;
+}
+
 error_code RawInstrProfReader::readHeader(const RawHeader &Header) {
   if (swap(Header.Version) != getRawVersion())
     return error(instrprof_error::unsupported_version);