[PATCH][ARM] Label offset crashes llvm integrated assembler

Renato Golin renato.golin at linaro.org
Fri Mar 21 03:13:51 PDT 2014


On 21 March 2014 03:00, Jiangning Liu <liujiangning1 at gmail.com> wrote:
> Hi Saleem,
>
> Your patch r203762 is reverted by r204427, because the fix is even worse
> than before, and it introduced silent failure.
>
> BTW, should we follow review process before committing any code to trunk?

Hi Jiangning, Saleem,

Yes, I agree we should still review IAS patches before commit, as they
tend to wash with the baby water on my stream and the IAS is not yet
stable or well tested to warrant quick changes.

cheers,
--renato



More information about the llvm-commits mailing list