[llvm] r204389 - [Constant Hoisting] Extend coverage of the constant hoisting pass.

[Eric Christopher]

Awesome. Thanks!

-eric

On Thursday, March 20, 2014, Juergen Ributzka <juergen at apple.com> wrote:

> Hi Eric,
>
> I fully agree with you. I didn't realize what little monster I created
> there over time. I decided to revert it and break it up a little, so it
> will be also more digestible later on if someone just sees the commits and
> not the review emails.
>
> Cheers,
> Juergen
>
> On Mar 20, 2014, at 1:29 PM, Eric Christopher <echristo at gmail.com> wrote:
>
> > For the record, feel free to post-commit review it per normal, it
> > wasn't that kind of request. Just "hey, can you make it easier to do
> > post-commit review on" :)
> >
> > -eric
> >
> > On Thu, Mar 20, 2014 at 1:24 PM, Eric Christopher <echristo at gmail.com>
> wrote:
> >> Really appreciate it. Thanks Juergen! :)
> >>
> >> -eric
> >>
> >> On Thu, Mar 20, 2014 at 1:21 PM, Juergen Ributzka <juergen at apple.com>
> wrote:
> >>> Ok, I will try to break it up into sensible pieces.
> >>>
> >>> -Juergen
> >>>
> >>> On Mar 20, 2014, at 1:13 PM, Eric Christopher <echristo at gmail.com>
> wrote:
> >>>
> >>>> Actually, this patch is almost impossible to review otherwise. Would
> >>>> you mind doing this? :)
> >>>>
> >>>> -eric
> >>>>
> >>>> On Thu, Mar 20, 2014 at 1:12 PM, Eric Christopher <echristo at gmail.com>
> wrote:
> >>>>> Is there some reason this couldn't be split out into refactoring and
> >>>>> then adding new functionality?
> >>>>>
> >>>>> -eric
> >>>>>
> >>>>> On Thu, Mar 20, 2014 at 12:55 PM, Juergen Ributzka <
> juergen at apple.com> wrote:
> >>>>>> Author: ributzka
> >>>>>> Date: Thu Mar 20 14:55:52 2014
> >>>>>> New Revision: 204389
> >>>>>>
> >>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=204389&view=rev
> >>>>>> Log:
> >>>>>> [Constant Hoisting] Extend coverage of the constant hoisting pass.
> >>>>>>
> >>>>>> This commit extends the coverage of the constant hoisting pass,
> adds additonal
> >>>>>> debug output and updates the function names according to the style
> guide.
> >>>>>>
> >>>>>> Related to <rdar://problem/16381500>
> >>>>>>
> >>>>>> Modified:
> >>>>>>   llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h
> >>>>>>   llvm/trunk/lib/Analysis/TargetTransformInfo.cpp
> >>>>>>   llvm/trunk/lib/Target/X86/X86TargetTransformInfo.cpp
> >>>>>>   llvm/trunk/lib/Transforms/Scalar/ConstantHoisting.cpp
> >>>>>>   llvm/trunk/test/CodeGen/X86/lsr-interesting-step.ll
> >>>>>>   llvm/trunk/test/CodeGen/X86/negate-add-zero.ll
> >>>>>>   llvm/trunk/test/Transforms/ConstantHoisting/X86/phi.ll
> >>>>>>
> >>>>>> Modified: llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h
> >>>>>> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h?rev=204389&r1=204388&r2=204389&view=diff
> >>>>>>
> ==============================================================================
> >>>>>> --- llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h
> (original)
> >>>>>> +++ llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h Thu Mar
> 20 14:55:52 2014
> >>>>>> @@ -297,10 +297,10 @@ public:
> >>>>>>  /// \brief Return the expected cost of materialization for the
> given integer
> >>>>>>  /// immediate of the specified type for a given instruction. The
> cost can be
> >>>>>>  /// zero if the immediate can be folded into the specified
> instruction.
> >>>>>> -  virtual unsigned getIntImmCost(unsigned Opcode, const APInt &Imm,
> >>>>>> -
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140321/dca8535b/attachment.html>