[PATCH] Object/COFF: Support large relocation table.

David Majnemer david.majnemer at gmail.com
Thu Mar 20 17:22:07 PDT 2014


  LGTM


================
Comment at: lib/Object/COFFObjectFile.cpp:376
@@ +375,3 @@
+    if (Sec->Characteristics & COFF::IMAGE_SCN_LNK_NRELOC_OVFL &&
+        Sec->NumberOfRelocations == UINT16_MAX) {
+      // Skip the first relocation entry repurposed to store the number of
----------------
`coff_section` should gain a method that contains this logic instead of duplicating it here and in `getNumberOfRelocations`.


http://llvm-reviews.chandlerc.com/D3139

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list