[llvm] r204094 - DebugInfo: Do not rely on the compilation dir (index 0) for files in line tables shared between compilation units

Eric Christopher echristo at gmail.com
Wed Mar 19 16:06:24 PDT 2014


> +  if (!Asm->OutStreamer.hasRawTextSupport() || Singular)
> +    Asm->OutStreamer.getContext().setMCLineTableCompilationDir(
> +        NewCU->getUniqueID(), CompilationDir);
>

This could probably use a comment above it taken from the commit
message. If you read the commit message it makes sense, however,
otherwise it might not be obvious.

>
>
> +; ASM: .file   1 "/tmp/dbginfo/a/a.cpp"
> +; ASM: .file   2 "/tmp/dbginfo/b/b.cpp"
> +

Comment above here saying what you're expecting?

-eric



More information about the llvm-commits mailing list