[compiler-rt] r202843 - tsan: add dynamic library target for standalone deadlock detector

[Dmitry Vyukov]

On Wed, Mar 12, 2014 at 7:08 PM, Kostya Serebryany <kcc at google.com> wrote:
>
>
>
> On Tue, Mar 4, 2014 at 4:52 PM, Dmitry Vyukov <dvyukov at google.com> wrote:
>>
>> Author: dvyukov
>> Date: Tue Mar  4 06:52:20 2014
>> New Revision: 202843
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=202843&view=rev
>> Log:
>> tsan: add dynamic library target for standalone deadlock detector
>> it's LD_PRELOAD-able
>>
>>
>>
>> Added:
>>     compiler-rt/trunk/lib/sanitizer_common/sanitizer_deadlock_detector2.cc
>> Modified:
>>     compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt
>>     compiler-rt/trunk/lib/sanitizer_common/sanitizer_deadlock_detector1.cc
>>
>> compiler-rt/trunk/lib/sanitizer_common/sanitizer_deadlock_detector_interface.h
>>     compiler-rt/trunk/lib/tsan/dd/CMakeLists.txt
>>     compiler-rt/trunk/lib/tsan/dd/dd_interceptors.cc
>>     compiler-rt/trunk/lib/tsan/dd/dd_rtl.cc
>>     compiler-rt/trunk/lib/tsan/dd/dd_rtl.h
>>
>> Modified: compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt
>> URL:
>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt?rev=202843&r1=202842&r2=202843&view=diff
>>
>> ==============================================================================
>> --- compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt (original)
>> +++ compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt Tue Mar  4
>> 06:52:20 2014
>> @@ -6,6 +6,7 @@ set(SANITIZER_SOURCES
>>    sanitizer_common.cc
>>    sanitizer_coverage.cc
>>    sanitizer_deadlock_detector1.cc
>> +  sanitizer_deadlock_detector2.cc
>>    sanitizer_flags.cc
>>    sanitizer_libc.cc
>>    sanitizer_libignore.cc
>>
>> Modified:
>> compiler-rt/trunk/lib/sanitizer_common/sanitizer_deadlock_detector1.cc
>> URL:
>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_deadlock_detector1.cc?rev=202843&r1=202842&r2=202843&view=diff
>>
>> ==============================================================================
>> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_deadlock_detector1.cc
>> (original)
>> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_deadlock_detector1.cc
>> Tue Mar  4 06:52:20 2014
>> @@ -17,6 +17,8 @@
>>  #include "sanitizer_placement_new.h"
>>  #include "sanitizer_mutex.h"
>>
>> +#if SANITIZER_DEADLOCK_DETECTOR_VERSION == 1
>> +
>>  namespace __sanitizer {
>>
>>  typedef TwoLevelBitVector<> DDBV;  // DeadlockDetector's bit vector.
>> @@ -142,3 +144,4 @@ void DDetectorImpl::MutexDestroy(DDPhysi
>>  }
>>
>>  }  // namespace __sanitizer
>> +#endif  // #if SANITIZER_DEADLOCK_DETECTOR_VERSION == 1
>>
>> Added:
>> compiler-rt/trunk/lib/sanitizer_common/sanitizer_deadlock_detector2.cc
>> URL:
>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_deadlock_detector2.cc?rev=202843&view=auto
>>
>> ==============================================================================
>> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_deadlock_detector2.cc
>> (added)
>> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_deadlock_detector2.cc
>> Tue Mar  4 06:52:20 2014
>> @@ -0,0 +1,139 @@
>> +//===-- sanitizer_deadlock_detector1.cc
>> -----------------------------------===//
>
>
> Could you please fix and enhance the comment for this file?

Done in r204231.