[llvm] r204178 - Add back r203962, r204028 and r204059.

[David Blaikie]

On Tue, Mar 18, 2014 at 4:58 PM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
> looking at it, thanks!

Would you mind reverting in the interim?

(& maybe some more general test coverage might come in handy)

>
> On 18 March 2014 16:41, Alexander Kornienko <alexfh at google.com> wrote:
>> A small repro:
>>
>> $ cat q.c
>> void a1();
>> void a2() __attribute__((alias("a1")));
>> void a3() __attribute__((alias("a2")));
>> int qqq(int a) { return a * a; }
>> void a1() {}
>>
>> $ clang-bad -c q.c && objdump -t q.o
>>
>> q.o:     file format elf64-x86-64
>>
>> SYMBOL TABLE:
>> 0000000000000000 l    df *ABS*  0000000000000000 q.c
>> 0000000000000000 l    d  .text  0000000000000000 .text
>> 0000000000000000 l    d  .data  0000000000000000 .data
>> 0000000000000000 l    d  .bss   0000000000000000 .bss
>> 0000000000000000 l    d  .comment       0000000000000000 .comment
>> 0000000000000000 l    d  .note.GNU-stack        0000000000000000
>> .note.GNU-stack
>> 0000000000000000 l    d  .eh_frame      0000000000000000 .eh_frame
>> 0000000000000020 g     F .text  0000000000000006 a1
>> 0000000000000020 g     F .text  0000000000000006 a2
>> 0000000000000000 g     F .text  0000000000000006 a3
>> 0000000000000000 g     F .text  0000000000000012 qqq
>>
>> $ clang-good -c q.c && objdump -t q.o
>>
>> q.o:     file format elf64-x86-64
>>
>> SYMBOL TABLE:
>> 0000000000000000 l    df *ABS*  0000000000000000 q.c
>> 0000000000000000 l    d  .text  0000000000000000 .text
>> 0000000000000000 l    d  .data  0000000000000000 .data
>> 0000000000000000 l    d  .bss   0000000000000000 .bss
>> 0000000000000000 l    d  .comment       0000000000000000 .comment
>> 0000000000000000 l    d  .note.GNU-stack        0000000000000000
>> .note.GNU-stack
>> 0000000000000000 l    d  .eh_frame      0000000000000000 .eh_frame
>> 0000000000000020 g     F .text  0000000000000006 a1
>> 0000000000000020 g     F .text  0000000000000006 a2
>> 0000000000000020 g     F .text  0000000000000006 a3
>> 0000000000000000 g     F .text  0000000000000012 qqq
>>
>>
>>
>>
>>
>> On Wed, Mar 19, 2014 at 12:32 AM, Alexander Kornienko <alexfh at google.com>
>> wrote:
>>>
>>> Got it: the same situation. Symbol is correctly marked as function, but
>>> the offset is 0. Do you need a test?
>>>
>>>
>>> On Wed, Mar 19, 2014 at 12:10 AM, Alexander Kornienko <alexfh at google.com>
>>> wrote:
>>>>
>>>> On Wed, Mar 19, 2014 at 12:08 AM, Rafael Espíndola
>>>> <rafael.espindola at gmail.com> wrote:
>>>>>
>>>>> On 18 March 2014 16:06, Alexander Kornienko <alexfh at google.com> wrote:
>>>>> > And it again breaks something for us. I assume, it's also related to
>>>>> > aliases, but it will take some time to figure out what exactly.
>>>>>
>>>>> Is it something I can reproduce locally?
>>>>
>>>>
>>>> I'm working on a compact repro.
>>>
>>>
>>>
>>>
>>> --
>>> Alexander Kornienko | Software Engineer | alexfh at google.com | +49 151 221
>>> 77 957
>>> Google Germany GmbH | Dienerstr. 12 | 80331 München
>>
>>
>>
>>
>> --
>> Alexander Kornienko | Software Engineer | alexfh at google.com | +49 151 221 77
>> 957
>> Google Germany GmbH | Dienerstr. 12 | 80331 München
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits