[llvm] r204176 - Remove a bunch of unnecessary includes and forward declarations.

[Eric Christopher]

>>  #include "DIE.h"
>>  #include "llvm/ADT/DenseMap.h"
>>  #include "llvm/ADT/FoldingSet.h"
>> -#include "llvm/ADT/MapVector.h"
>> -#include "llvm/ADT/SetVector.h"
>> -#include "llvm/ADT/SmallPtrSet.h"
>> -#include "llvm/ADT/StringMap.h"
>>  #include "llvm/CodeGen/LexicalScopes.h"
>>  #include "llvm/IR/DebugInfo.h"
>> -#include "llvm/IR/DebugLoc.h"
>
> These header removals might be a bit aggressive/brittle - looks like
> we need/use most of these in this header and should include them
> explicitly here rather than getting them implicitly from other headers
> we're including (modules will fix this kind of header leakage - yay!)

Agreed. Fixed.

>> -class DIEAbbrev;
>> -class DIE;
>> -class DIELoc;
>> -class DIEEntry;
>
> Hmm - could we just use these forward decls instead of including
> DIE.h? Wonder what we need from DIE.h

The folding set wants to instantiate a DIEAbbrev unfortunately.

-eric

>
>>
>>  //===----------------------------------------------------------------------===//
>>  /// \brief This class is used to record source line correspondence.
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits