[PATCH] Adapt MipsLongBranch pass to work in NaCl.
Daniel Sanders
daniel.sanders at imgtec.com
Tue Mar 18 07:12:42 PDT 2014
================
Comment at: test/MC/Mips/nacl-long-branch.ll:2
@@ +1,3 @@
+; RUN: llc -filetype=obj -O3 -mtriple mipsel-none-linux < %s \
+; RUN: | llvm-objdump -triple mipsel -disassemble -no-show-raw-insn - \
+; RUN: | FileCheck %s
----------------
Mark Seaborn wrote:
> Why not test llc's assembly output rather than its object file output? That should be easier to read and maintain.
I agree we should be using llc's assembly output.
In general, 'llc -filetype=obj' tests should be split into separate CodeGen and MC parts. We need to be able to assemble anything CodeGen emits.
http://llvm-reviews.chandlerc.com/D3089
More information about the llvm-commits
mailing list