[PATCH] Add ARM big endian Target (armeb, thumbeb)

Bernard Ogden bernard.ogden at arm.com
Tue Mar 18 02:50:32 PDT 2014


  I'm just reviewing round the edges i.e. do the target names look sensible and seem to mean the right things.

  I'd like to see some tests that:

  1) The new triples produce objects that declare big-endianness - and, now that it's relevant, that the old triples produce objects that declare little-endianness. Something like test/MC/Mips/elf_basic.s, perhaps.
  2) The new triples produce the right subtarget features (re my inline comments).

  Do we have such tests on the AArch64 side? I didn't see any last time I looked.


================
Comment at: lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp:96
@@ -94,1 +95,3 @@
     Idx = 4;
+  else if (Len >= 5 && TT.substr(0, 4) == "armebv")
+    Idx = 6;
----------------
Oops, bad numbers

================
Comment at: lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp:100
@@ -96,1 +99,3 @@
     Idx = 6;
+  else if (Len >= 7 && TT.substr(0, 6) == "thumbebv")
+    Idx = 8;
----------------
Oops, bad numbers


http://llvm-reviews.chandlerc.com/D3095



More information about the llvm-commits mailing list