[llvm] r204019 - Add FIXMEs to use DIScopeRef instead of DIScope for LTO type uniqueing.

[Manman Ren]

On Mon, Mar 17, 2014 at 11:00 AM, Adrian Prantl <aprantl at apple.com> wrote:

> On Mar 16, 2014, at 11:44, Manman Ren <manman.ren at gmail.com> wrote:
>
> > Author: mren
> > Date: Sun Mar 16 13:44:23 2014
> > New Revision: 204019
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=204019&view=rev
> > Log:
> > Add FIXMEs to use DIScopeRef instead of DIScope for LTO type uniqueing.
> >
> > Modified:
> >    llvm/trunk/include/llvm/IR/DebugInfo.h
> >
> > Modified: llvm/trunk/include/llvm/IR/DebugInfo.h
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/DebugInfo.h?rev=204019&r1=204018&r2=204019&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/include/llvm/IR/DebugInfo.h (original)
> > +++ llvm/trunk/include/llvm/IR/DebugInfo.h Sun Mar 16 13:44:23 2014
> > @@ -605,6 +605,7 @@ class DIGlobalVariable : public DIDescri
> > public:
> >   explicit DIGlobalVariable(const MDNode *N = 0) : DIDescriptor(N) {}
> >
> > +  // FIXME: use DIScopeRef for LTO type uniqueing.
> >   DIScope getContext() const { return getFieldAs<DIScope>(2); }
>
> Working on this now. Quick question -- shouldn't these comments rather
> refer to the getType() functions instead of the lexical scope?
>

Yes, we should convert DIType to DITypeRef and DIScope to DIScopeRef when
applicable (i.e when the scope can be a type with a type identifier).

Thanks,
Manman


> -- adrian
>
> >   StringRef getName() const { return getStringField(3); }
> >   StringRef getDisplayName() const { return getStringField(4); }
> > @@ -638,6 +639,7 @@ class DIVariable : public DIDescriptor {
> > public:
> >   explicit DIVariable(const MDNode *N = 0) : DIDescriptor(N) {}
> >
> > +  // FIXME: use DIScopeRef for LTO type uniqueing.
> >   DIScope getContext() const { return getFieldAs<DIScope>(1); }
> >   StringRef getName() const { return getStringField(2); }
> >   DIFile getFile() const { return getFieldAs<DIFile>(3); }
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140317/ca85590d/attachment.html>