[PATCH] Use DiagnosticInfo facility.

[Quentin Colombet]

  Hi Diego,

  This overall LGTM with minor changes (see my inline comments).

  Thanks,
  -Quentin


================
Comment at: lib/Transforms/Scalar/SampleProfile.cpp:52
@@ -51,2 +51,3 @@
 #include "llvm/Support/raw_ostream.h"
+#include "llvm/IR/DiagnosticInfo.h"
 #include <cctype>
----------------
Includes should be sorted.

================
Comment at: lib/Transforms/Scalar/SampleProfile.cpp:97
@@ -95,3 +96,3 @@
   static inline unsigned getHashValue(InstructionLocation Val) {
-    return DenseMapInfo<std::pair<int, unsigned> >::getHashValue(
+    return DenseMapInfo<std::pair<int, unsigned>>::getHashValue(
         std::pair<int, unsigned>(Val.LineOffset, Val.Discriminator));
----------------
This shouldn’t be part of this patch.

================
Comment at: lib/Transforms/Scalar/SampleProfile.cpp:113
@@ -111,3 +112,3 @@
 typedef DenseMap<Edge, unsigned> EdgeWeightMap;
-typedef DenseMap<BasicBlock *, SmallVector<BasicBlock *, 8> > BlockEdgeMap;
+typedef DenseMap<BasicBlock *, SmallVector<BasicBlock *, 8>> BlockEdgeMap;
 
----------------
Ditto.


http://llvm-reviews.chandlerc.com/D3086

BRANCH
  diagnostic-info

ARCANIST PROJECT
  llvm