[PATCH] Make GDBJITRegistrar thread-safe

[Ivan Puzyrevskiy]

The one attached to the first email in this thread.
Reattaching it for convenience.

Best,
Ivan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gdbjitregistrar.patch
Type: application/octet-stream
Size: 2929 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140314/5e023f7d/attachment.obj>
-------------- next part --------------

On 13 марта 2014 г., at 22:15, Eric Christopher <echristo at gmail.com> wrote:

> I'll get it. Which patches need to be applied?
> 
> -eric
> 
> On Thu, Mar 13, 2014 at 10:57 AM, Kaylor, Andrew
> <andrew.kaylor at intel.com> wrote:
>> Hi Ivan,
>> 
>> 
>> 
>> I'm not properly setup to commit this at the moment.  I was hoping either
>> Tim or Lang would be willing to commit it.
>> 
>> 
>> 
>> -Andy
>> 
>> 
>> 
>> From: Ivan Puzyrevskiy [mailto:sandello at yandex-team.ru]
>> Sent: Thursday, March 13, 2014 10:49 AM
>> To: Kaylor, Andrew
>> Cc: llvm-commits at cs.uiuc.edu; jim.kearney at oracle.com; Lang Hames
>> (lhames at apple.com); Tim Northover
>> Subject: Re: [PATCH] Make GDBJITRegistrar thread-safe
>> 
>> 
>> 
>> Jim pointed out to me that patch was approved some time ago but it didn't
>> make its way to the trunk. See:
>> 
>> 
>> 
>> http://comments.gmane.org/gmane.comp.compilers.llvm.cvs/161966
>> http://comments.gmane.org/gmane.comp.compilers.llvm.cvs/161965
>> 
>> 
>> 
>> Andy, if this patch would be approved can I ask you to commit it? Neither me
>> nor Jim has commit rights.
>> 
>> 
>> 
>> Best,
>> 
>> Ivan.
>> 
>> 
>> 
>> On 13 марта 2014 г., at 21:45, Kaylor, Andrew <andrew.kaylor at intel.com>
>> wrote:
>> 
>> 
>> 
>> That looks good as an intermediate fix.
>> 
>> 
>> 
>> In the long term I think the GDB registration should probably be moved out
>> of RuntimeDyldELF (maybe to an event listener), but these changes would
>> probably be nice to have even then.
>> 
>> 
>> 
>> -Andy
>> 
>> 
>> 
>> From: llvm-commits-bounces at cs.uiuc.edu
>> [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Ivan Puzyrevskiy
>> Sent: Thursday, March 13, 2014 4:45 AM
>> To: llvm-commits at cs.uiuc.edu
>> Cc: jim.kearney at oracle.com
>> Subject: [PATCH] Make GDBJITRegistrar thread-safe
>> 
>> 
>> 
>> Hi there.
>> 
>> While investigating a crash in GDBJITRegistrar I have stumbled upon
>> http://llvm.org/bugs/show_bug.cgi?id=15750 . In my setting there were
>> multiple instances of MCJIT operating in different threads.
>> 
>> Patch from Bugzilla applies cleanly and solves the issue. I have attached a
>> patch against r203780, yet full credit goes to Jim Kearney
>> (jim.kearney at oracle.com), original author of the patch.
>> 
>> Any chances to see this in the trunk or 3.5 release?
>> 
>> Best,
>> Ivan
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>