[PATCH] [C++11] Introduce ObjectFile::sections().
Rafael Ávila de Espíndola
rafael.espindola at gmail.com
Thu Mar 13 06:12:10 PDT 2014
LGTM with two nits.
================
Comment at: lib/MC/MCObjectDisassembler.cpp:91
@@ +90,3 @@
+ for (const SectionRef &Section : Obj.sections()) {
+ bool isText; Section.isText(isText);
+ bool isData; Section.isData(isData);
----------------
Newline after the ;
In fact, please git-clang-format the patch :-)
================
Comment at: lib/DebugInfo/DWARFContext.cpp:608
@@ -607,7 +607,3 @@
-DWARFContextInMemory::DWARFContextInMemory(object::ObjectFile *Obj) :
- IsLittleEndian(Obj->isLittleEndian()),
- AddressSize(Obj->getBytesInAddress()) {
- for (object::section_iterator i = Obj->section_begin(),
- e = Obj->section_end();
- i != e; ++i) {
+DWARFContextInMemory::DWARFContextInMemory(object::ObjectFile *Obj)
+ : IsLittleEndian(Obj->isLittleEndian()),
----------------
Unrelated change?
http://llvm-reviews.chandlerc.com/D3069
BRANCH
svn
ARCANIST PROJECT
llvm
More information about the llvm-commits
mailing list