[PATCH] Emit DWARF info for all code section in an assembly file

Eric Christopher echristo at gmail.com
Wed Mar 12 15:50:50 PDT 2014



================
Comment at: lib/MC/MCDwarf.cpp:615
@@ -596,1 +614,3 @@
+  // The 2 byte DWARF version.
+  MCOS->EmitIntValue(context.getDwarfVersion(), 2);
 
----------------
Oliver Stannard wrote:
> Eric Christopher wrote:
> > EmitInt16.
> EmitInt16 is a method of AsmPrinter, and we are not outputting assembly here. Every other place in this file uses EmitIntValue.
Seems sad. I guess that can be a refactor.


http://llvm-reviews.chandlerc.com/D2697



More information about the llvm-commits mailing list