[PATCH] An analysis to find external function pointers and trace their data flow

Tom Roeder tmroeder at google.com
Wed Mar 12 12:21:13 PDT 2014



================
Comment at: lib/Analysis/ExternalFunctionAnalysis.cpp:432
@@ +431,3 @@
+
+    // Don't chase values from operator new.
+    std::string Name(F->getName());
----------------
JF Bastien wrote:
> Why not malloc too? Is this just a performance thing, or does it impact correctness?
Memory allocation functions are a frequent source of false positives, so the code tries to skip them. I see what you mean though, about malloc, and in the next revision, I've switched to using TargetLibraryInfo and adding other memory allocation functions from it.


http://llvm-reviews.chandlerc.com/D2873



More information about the llvm-commits mailing list