[PATCH] Implement NaCl sandboxing of function calls

Sasa Stankovic Sasa.Stankovic at imgtec.com
Tue Mar 11 08:01:10 PDT 2014



================
Comment at: test/MC/Mips/nacl-mask.s:12
@@ -11,2 +11,3 @@
 
+	.align	4
 test1:
----------------
Mark Seaborn wrote:
> Is the reason for adding this that EmitBundleLock(true) complains if an alignment hasn't been set already?  Or does the test work without adding this .align?
No, I added this because llvm-mc doesn't call AsmPrinter::runOnMachineFunction, which means that functions are not bundle-aligned. Test expects that function start is bundle-aligned.


http://llvm-reviews.chandlerc.com/D3032



More information about the llvm-commits mailing list