[llvm] r203287 - Actually include the ArrayRef header rather than rely on the forward

[Eric Christopher]

On Sat, Mar 8, 2014 at 7:04 AM, Duncan Exon Smith <dexonsmith at apple.com> wrote:
>
>> On Mar 7, 2014, at 13:30, Eric Christopher <echristo at gmail.com> wrote:
>>
>> Author: echristo
>> Date: Fri Mar  7 15:30:49 2014
>> New Revision: 203287
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=203287&view=rev
>> Log:
>> Actually include the ArrayRef header rather than rely on the forward
>> declaration.
>
> I'm curious.  Why?
>

Can't get the type deduction in one of the followup patches otherwise
(the update on HashingByteStreamer). In retrospect the rest of the
code likely only worked via transitive includes in the first place.

-eric

>>
>> Modified:
>>    llvm/trunk/include/llvm/Support/MD5.h
>>
>> Modified: llvm/trunk/include/llvm/Support/MD5.h
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/MD5.h?rev=203287&r1=203286&r2=203287&view=diff
>> ==============================================================================
>> --- llvm/trunk/include/llvm/Support/MD5.h (original)
>> +++ llvm/trunk/include/llvm/Support/MD5.h Fri Mar  7 15:30:49 2014
>> @@ -28,13 +28,12 @@
>> #ifndef LLVM_SYSTEM_MD5_H
>> #define LLVM_SYSTEM_MD5_H
>>
>> +#include "llvm/ADT/ArrayRef.h"
>> #include "llvm/ADT/SmallString.h"
>> #include "llvm/Support/DataTypes.h"
>>
>> namespace llvm {
>>
>> -template <typename T> class ArrayRef;
>> -
>> class MD5 {
>>   // Any 32-bit or wider unsigned integer data type will do.
>>   typedef uint32_t MD5_u32plus;
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits