[llvm] r203343 - [bugpoint] Don't ignore arg in -compile-commad="tool arg"

Adam Nemet anemet at apple.com
Sat Mar 8 01:00:15 PST 2014


I’ll try to come up with something.  This needs an external script so portability may become issue.  I’ll try it with python.

Unfortunately, when the original feature was added (—compile-custom —compile-command,) there was no test added.  So it’s not that I could just piggyback on something.

Adam

On Mar 8, 2014, at 12:18 AM, David Blaikie <dblaikie at gmail.com> wrote:

> Any chance of test cases?
> 
> On Mar 7, 2014 11:56 PM, "Adam Nemet" <anemet at apple.com> wrote:
> Author: anemet
> Date: Sat Mar  8 01:48:19 2014
> New Revision: 203343
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=203343&view=rev
> Log:
> [bugpoint] Don't ignore arg in -compile-commad="tool arg"
> 
> Args is an output parameter of the function lexCommand but the reference
> operator was missed.
> 
> Modified:
>     llvm/trunk/tools/bugpoint/ToolRunner.cpp
> 
> Modified: llvm/trunk/tools/bugpoint/ToolRunner.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/bugpoint/ToolRunner.cpp?rev=203343&r1=203342&r2=203343&view=diff
> ==============================================================================
> --- llvm/trunk/tools/bugpoint/ToolRunner.cpp (original)
> +++ llvm/trunk/tools/bugpoint/ToolRunner.cpp Sat Mar  8 01:48:19 2014
> @@ -406,7 +406,7 @@ int CustomExecutor::ExecuteProgram(const
>  // code borrowed from:
>  // http://oopweb.com/CPP/Documents/CPPHOWTO/Volume/C++Programming-HOWTO-7.html
>  static void lexCommand(std::string &Message, const std::string &CommandLine,
> -                       std::string &CmdPath, std::vector<std::string> Args) {
> +                       std::string &CmdPath, std::vector<std::string> &Args) {
> 
>    std::string Command = "";
>    std::string delimiters = " ";
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140308/e7740bf1/attachment.html>


More information about the llvm-commits mailing list