[PATCH] Qt Creator help/documentation file for LLVM

Michael Gottesman mgottesman at apple.com
Fri Mar 7 11:18:27 PST 2014


  Small nit, but I will just fix it and commit it.


================
Comment at: docs/CMakeLists.txt:39
@@ +38,3 @@
+      DOC "Path to the qhelpgenerator binary")
+    if (LLVM_DOXYGEN_QHELPGENERATOR_PATH)
+      set(llvm_doxygen_generate_qhp "YES")
----------------
One last nit. In general in LLVM we prefer to do this sort of thing like this:

if (NOT LLVM_DOXYGEN_QHELPGENERATOR_PATH)
    message(FATAL_ERROR "Failed to find qhelpgenerator binary")
endif()

set(llvm_doxygen_generate_qhp "YES")
set(llvm_doxygen_qch_filename "${LLVM_DOXYGEN_QCH_FILENAME}")
set(llvm_doxygen_qhp_namespace "${LLVM_DOXYGEN_QHP_NAMESPACE}")
set(llvm_doxygen_qhelpgenerator_path "${LLVM_DOXYGEN_QHELPGENERATOR_PATH}")
set(llvm_doxygen_qhp_cust_filter_name "${LLVM_DOXYGEN_QHP_CUST_FILTER_NAME}")
set(llvm_doxygen_qhp_cust_filter_attrs "${LLVM_DOXYGEN_QHP_CUST_FILTER_ATTRS}")

But I will just fix it since it is such a nit.


http://llvm-reviews.chandlerc.com/D2967

BRANCH
  master

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list