[llvm] r203192 - DebugInfo: Limit r203187 to non-darwin as lldb can't handle this yet

[Adrian Prantl]

Thanks for the heads-up, David. According to Greg it should be fairly straightforward to support this in LLDB.

On Mar 6, 2014, at 18:29, David Blaikie <dblaikie at gmail.com> wrote:

> On Thu, Mar 6, 2014 at 6:19 PM, David Blaikie <dblaikie at gmail.com> wrote:
>> Author: dblaikie
>> Date: Thu Mar  6 20:19:41 2014
>> New Revision: 203192
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=203192&view=rev
>> Log:
>> DebugInfo: Limit r203187 to non-darwin as lldb can't handle this yet
> 
> Adrian, Greg,
> 
> You guys might want to consider supporting this in lld as it'll reduce
> the number of relocations for debug info quite substantially (I
> haven't gathered numbers yet, but working on it - we're over 50%
> higher on relocations in debug_info than GCC ToT, we're hoping this
> issue is most of that)
> 
>> 
>> Modified:
>>    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>>    llvm/trunk/test/DebugInfo/X86/dbg-value-location.ll
>> 
>> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=203192&r1=203191&r2=203192&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
>> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Thu Mar  6 20:19:41 2014
>> @@ -413,8 +413,11 @@ DIE *DwarfDebug::updateSubprogramScopeDI
>>   }
>> 
>>   SPCU->addLabelAddress(SPDie, dwarf::DW_AT_low_pc, FunctionBeginSym);
>> -  SPCU->addLabelDelta(SPDie, dwarf::DW_AT_high_pc, FunctionEndSym,
>> -                      FunctionBeginSym);
>> +  if (Triple(Asm->getTargetTriple()).isOSDarwin())
>> +    SPCU->addLabelAddress(SPDie, dwarf::DW_AT_high_pc, FunctionEndSym);
>> +  else
>> +    SPCU->addLabelDelta(SPDie, dwarf::DW_AT_high_pc, FunctionEndSym,
>> +                        FunctionBeginSym);
>> 

The fact that this works makes me wonder if the Linux-based LLDB buildbots have all retired?
*checks http://lab.llvm.org:8011* ... no they’re red, but for different reasons :-(

-- adrian

>>   const TargetRegisterInfo *RI = Asm->TM.getRegisterInfo();
>>   MachineLocation Location(RI->getFrameRegister(*Asm->MF));
>> 
>> Modified: llvm/trunk/test/DebugInfo/X86/dbg-value-location.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/dbg-value-location.ll?rev=203192&r1=203191&r2=203192&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/DebugInfo/X86/dbg-value-location.ll (original)
>> +++ llvm/trunk/test/DebugInfo/X86/dbg-value-location.ll Thu Mar  6 20:19:41 2014
>> @@ -4,7 +4,7 @@ target datalayout = "e-p:64:64:64-i1:8:8
>> target triple = "x86_64-apple-darwin10.0.0"
>> ;Radar 8950491
>> 
>> -;CHECK: .long Lset6
>> +;CHECK: .long Lset5
>> ;CHECK-NEXT:        ## DW_AT_decl_file
>> ;CHECK-NEXT:        ## DW_AT_decl_line
>> ;CHECK-NEXT:        ## DW_AT_type
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits