[lld] r203102 - [Mips] Replace "virtual" by "override" in member function declarations
Simon Atanasyan
simon at atanasyan.com
Thu Mar 6 02:29:45 PST 2014
Author: atanasyan
Date: Thu Mar 6 04:29:45 2014
New Revision: 203102
URL: http://llvm.org/viewvc/llvm-project?rev=203102&view=rev
Log:
[Mips] Replace "virtual" by "override" in member function declarations
where it is appropriate.
Modified:
lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h
lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicTable.h
lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h
lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.h
lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationHandler.h
lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp
lld/trunk/lib/ReaderWriter/ELF/Mips/MipsSectionChunks.h
lld/trunk/lib/ReaderWriter/ELF/Mips/MipsTargetHandler.h
Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h?rev=203102&r1=203101&r2=203102&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h Thu Mar 6 04:29:45 2014
@@ -28,11 +28,11 @@ public:
protected:
// Add any runtime files and their atoms to the output
- virtual bool createImplicitFiles(std::vector<std::unique_ptr<File>> &);
+ bool createImplicitFiles(std::vector<std::unique_ptr<File>> &) override;
- virtual void finalizeDefaultAtomValues();
+ void finalizeDefaultAtomValues() override;
- virtual error_code setELFHeader() {
+ error_code setELFHeader() override {
DynamicLibraryWriter<ELFT>::setELFHeader();
MipsELFWriter<ELFT>::setELFHeader(*this->_elfHeader);
return error_code::success();
Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicTable.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicTable.h?rev=203102&r1=203101&r2=203102&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicTable.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicTable.h Thu Mar 6 04:29:45 2014
@@ -27,7 +27,7 @@ public:
DefaultLayout<MipsELFType>::ORDER_DYNAMIC),
_mipsTargetLayout(layout) {}
- virtual void createDefaultEntries() {
+ void createDefaultEntries() override {
DynamicTable<MipsELFType>::createDefaultEntries();
typename DynamicTable<MipsELFType>::Elf_Dyn dyn;
@@ -69,7 +69,7 @@ public:
_dt_pltgot = this->addEntry(dyn);
}
- virtual void updateDynamicTable() {
+ void updateDynamicTable() override {
DynamicTable<MipsELFType>::updateDynamicTable();
// Assign the minimum segment address to the DT_MIPS_BASE_ADDRESS tag.
@@ -89,7 +89,7 @@ public:
_mipsTargetLayout.findOutputSection(".got")->virtualAddr();
}
- virtual int64_t getGotPltTag() { return DT_MIPS_PLTGOT; }
+ int64_t getGotPltTag() override { return DT_MIPS_PLTGOT; }
private:
std::size_t _dt_symtabno;
Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h?rev=203102&r1=203101&r2=203102&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h Thu Mar 6 04:29:45 2014
@@ -27,14 +27,14 @@ public:
MipsTargetLayout<ELFT> &layout);
protected:
- virtual void buildDynamicSymbolTable(const File &file);
+ void buildDynamicSymbolTable(const File &file) override;
// Add any runtime files and their atoms to the output
- virtual bool createImplicitFiles(std::vector<std::unique_ptr<File>> &);
+ bool createImplicitFiles(std::vector<std::unique_ptr<File>> &) override;
- virtual void finalizeDefaultAtomValues();
+ void finalizeDefaultAtomValues() override;
- virtual error_code setELFHeader() {
+ error_code setELFHeader() override {
ExecutableWriter<ELFT>::setELFHeader();
MipsELFWriter<ELFT>::setELFHeader(*this->_elfHeader);
return error_code::success();
Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.h?rev=203102&r1=203101&r2=203102&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.h Thu Mar 6 04:29:45 2014
@@ -40,15 +40,15 @@ public:
const MipsTargetLayout<Mips32ElELFType> &getTargetLayout() const;
// ELFLinkingContext
- virtual bool isLittleEndian() const;
- virtual uint64_t getBaseAddress() const;
- virtual StringRef entrySymbolName() const;
- virtual StringRef getDefaultInterpreter() const;
- virtual void addPasses(PassManager &pm);
- virtual bool isRelaOutputFormat() const { return false; }
- virtual bool isDynamicRelocation(const DefinedAtom &,
- const Reference &r) const;
- virtual bool isPLTRelocation(const DefinedAtom &, const Reference &r) const;
+ bool isLittleEndian() const override;
+ uint64_t getBaseAddress() const override;
+ StringRef entrySymbolName() const override;
+ StringRef getDefaultInterpreter() const override;
+ void addPasses(PassManager &pm) override;
+ bool isRelaOutputFormat() const override { return false; }
+ bool isDynamicRelocation(const DefinedAtom &,
+ const Reference &r) const override;
+ bool isPLTRelocation(const DefinedAtom &, const Reference &r) const override;
};
} // elf
Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationHandler.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationHandler.h?rev=203102&r1=203101&r2=203102&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationHandler.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationHandler.h Thu Mar 6 04:29:45 2014
@@ -25,9 +25,9 @@ public:
~MipsTargetRelocationHandler();
- virtual error_code applyRelocation(ELFWriter &, llvm::FileOutputBuffer &,
- const lld::AtomLayout &,
- const Reference &) const;
+ error_code applyRelocation(ELFWriter &, llvm::FileOutputBuffer &,
+ const lld::AtomLayout &,
+ const Reference &) const override;
private:
typedef std::vector<const Reference *> PairedRelocationsT;
Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp?rev=203102&r1=203101&r2=203102&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp Thu Mar 6 04:29:45 2014
@@ -49,7 +49,7 @@ class MipsGOTAtom : public GOTAtom {
public:
MipsGOTAtom(const File &f) : GOTAtom(f, ".got") {}
- virtual Alignment alignment() const { return Alignment(2); }
+ Alignment alignment() const override { return Alignment(2); }
};
/// \brief MIPS GOT entry initialized by zero.
@@ -57,7 +57,7 @@ class GOT0Atom : public MipsGOTAtom {
public:
GOT0Atom(const File &f) : MipsGOTAtom(f) {}
- virtual ArrayRef<uint8_t> rawContent() const {
+ ArrayRef<uint8_t> rawContent() const override {
return llvm::makeArrayRef(mipsGot0AtomContent);
}
};
@@ -67,7 +67,7 @@ class GOTModulePointerAtom : public Mips
public:
GOTModulePointerAtom(const File &f) : MipsGOTAtom(f) {}
- virtual ArrayRef<uint8_t> rawContent() const {
+ ArrayRef<uint8_t> rawContent() const override {
return llvm::makeArrayRef(mipsGotModulePointerAtomContent);
}
};
@@ -76,7 +76,7 @@ class PLT0Atom : public PLTAtom {
public:
PLT0Atom(const File &f) : PLTAtom(f, ".plt") {}
- virtual ArrayRef<uint8_t> rawContent() const {
+ ArrayRef<uint8_t> rawContent() const override {
return llvm::makeArrayRef(mipsPlt0AtomContent);
}
};
@@ -85,7 +85,7 @@ class PLTAAtom : public PLTAtom {
public:
PLTAAtom(const File &f) : PLTAtom(f, ".plt") {}
- virtual ArrayRef<uint8_t> rawContent() const {
+ ArrayRef<uint8_t> rawContent() const override {
return llvm::makeArrayRef(mipsPltAAtomContent);
}
};
@@ -95,9 +95,9 @@ class GOTPLTAtom : public GOTAtom {
public:
GOTPLTAtom(const File &f) : GOTAtom(f, ".got.plt") {}
- virtual Alignment alignment() const { return Alignment(2); }
+ Alignment alignment() const override { return Alignment(2); }
- virtual ArrayRef<uint8_t> rawContent() const {
+ ArrayRef<uint8_t> rawContent() const override {
return llvm::makeArrayRef(mipsGot0AtomContent);
}
};
@@ -120,7 +120,7 @@ public:
_localGotVector.push_back(new (_file._alloc) GOTModulePointerAtom(_file));
}
- virtual void perform(std::unique_ptr<MutableFile> &mf) {
+ void perform(std::unique_ptr<MutableFile> &mf) override {
// Process all references.
for (const auto &atom : mf->defined())
for (const auto &ref : *atom)
Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsSectionChunks.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsSectionChunks.h?rev=203102&r1=203101&r2=203102&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsSectionChunks.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsSectionChunks.h Thu Mar 6 04:29:45 2014
@@ -49,7 +49,7 @@ public:
return ia == _posMap.end() && ib != _posMap.end();
}
- virtual const lld::AtomLayout &appendAtom(const Atom *atom) {
+ const lld::AtomLayout &appendAtom(const Atom *atom) override {
const DefinedAtom *da = dyn_cast<DefinedAtom>(atom);
const Atom *ta = nullptr;
Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsTargetHandler.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsTargetHandler.h?rev=203102&r1=203101&r2=203102&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsTargetHandler.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsTargetHandler.h Thu Mar 6 04:29:45 2014
@@ -29,10 +29,10 @@ public:
const MipsGOTSection<ELFType> &getGOTSection() const { return *_gotSection; }
- virtual AtomSection<ELFType> *
+ AtomSection<ELFType> *
createSection(StringRef name, int32_t type,
DefinedAtom::ContentPermissions permissions,
- Layout::SectionOrder order) {
+ Layout::SectionOrder order) override {
if (type == DefinedAtom::typeGOT && name == ".got")
return _gotSection;
return DefaultLayout<ELFType>::createSection(name, type, permissions,
@@ -72,17 +72,17 @@ class MipsTargetHandler final
public:
MipsTargetHandler(MipsLinkingContext &context);
- virtual MipsTargetLayout<Mips32ElELFType> &getTargetLayout() {
+ MipsTargetLayout<Mips32ElELFType> &getTargetLayout() override {
return *(_mipsTargetLayout.get());
}
- virtual const MipsTargetRelocationHandler &getRelocationHandler() const {
+ const MipsTargetRelocationHandler &getRelocationHandler() const override {
return *(_mipsRelocationHandler.get());
}
- virtual std::unique_ptr<Writer> getWriter();
+ std::unique_ptr<Writer> getWriter() override;
- virtual void registerRelocationNames(Registry ®istry);
+ void registerRelocationNames(Registry ®istry) override ;
private:
static const Registry::KindStrings kindStrings[];
@@ -101,7 +101,7 @@ public:
DefaultLayout<Mips32ElELFType>::ORDER_DYNAMIC_SYMBOLS),
_mipsTargetLayout(layout) {}
- virtual void sortSymbols() {
+ void sortSymbols() override {
std::stable_sort(_symbolTable.begin(), _symbolTable.end(),
[this](const SymbolEntry &A, const SymbolEntry &B) {
if (A._symbol.getBinding() != STB_GLOBAL &&
More information about the llvm-commits
mailing list