[llvm] r203055 - Add some helpful comments on DIEValue types that we expect to hash.

Eric Christopher echristo at gmail.com
Wed Mar 5 17:32:56 PST 2014


Author: echristo
Date: Wed Mar  5 19:32:56 2014
New Revision: 203055

URL: http://llvm.org/viewvc/llvm-project?rev=203055&view=rev
Log:
Add some helpful comments on DIEValue types that we expect to hash.

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/DIEHash.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DIEHash.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DIEHash.cpp?rev=203055&r1=203054&r2=203055&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DIEHash.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DIEHash.cpp Wed Mar  5 19:32:56 2014
@@ -346,12 +346,15 @@ void DIEHash::hashAttribute(AttrEntry At
       hashBlockData(cast<DIELoc>(Value)->getValues());
     }
     break;
+    // FIXME: Handle loclistptr.
+  case DIEValue::isLocList:
+    // FIXME: It's uncertain whether or not we should handle this at the moment.
   case DIEValue::isExpr:
   case DIEValue::isLabel:
   case DIEValue::isDelta:
+    // These two were handled above.
   case DIEValue::isEntry:
   case DIEValue::isTypeSignature:
-  case DIEValue::isLocList:
     llvm_unreachable("Add support for additional value types.");
   }
 }





More information about the llvm-commits mailing list