[PATCH] Added address sanitizer instrumentation for MOV and MOVAPS inline assembly instructions.

[Rafael Ávila de Espíndola]

================
Comment at: lib/Target/X86/AsmParser/X86AsmInstrumentation.h:29
@@ +28,3 @@
+  // instruction is sent to |Out|.
+  virtual bool InstrumentInstruction(
+      const MCInst& Inst,
----------------
The bool return is never used. Using |foo| to refer to comments is not very common in llvm.

================
Comment at: lib/Target/X86/AsmParser/X86AsmInstrumentation.h:39
@@ +38,3 @@
+
+class X86AsmInstrumentationFactory {
+ public:
----------------
Why have a class with just a static method in it? Just add a regular function in the llvm namespace.

================
Comment at: lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp:39
@@ +38,3 @@
+
+class X86StubInstrumentation : public X86AsmInstrumentation {
+public:
----------------
Is there value in having a stub implementation instead of making the base a do nothing implementation?


http://llvm-reviews.chandlerc.com/D2881