[PATCH] Canonicalise Windows target triple spellings

[Reid Kleckner]

On Tue, Mar 4, 2014 at 3:36 PM, Saleem Abdulrasool <abdulras at fb.com> wrote:

>
> > ================
> > Comment at: include/llvm/ADT/Triple.h:334
> > @@ -329,2 +333,3 @@
> >   bool isOSCygMing() const {
> > -    return getOS() == Triple::Cygwin || getOS() == Triple::MinGW32;
> > +    return getOS() == Triple::Cygwin || getOS() == Triple::MinGW32 ||
> > +           (getOS() == Triple::Win32 && (getEnvironment() ==
> Triple::Cygnus ||
> > ----------------
> > Are you planning to remove the MinGW32 OS enum?
>
> Yes, I would like to rename Win32 to Windows and remove MinGW32.  However,
> Id like to do that in a subsequent pass.  I don’t have a strong opinion on
> that, and if you think that it is better done in one shot, Im happy to
> merge that into this change.


No, I think it's better to do this incrementally, so that Clang and other
consumers of LLVM can look for the new environment.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140304/e413a94b/attachment.html>