[compiler-rt] r202845 - [ASan] Speed up stack trace unwinding for stacks of size 2.

[Dmitri Gribenko]

On Tue, Mar 4, 2014 at 1:12 PM, Alexey Samsonov <samsonov at google.com> wrote:
> Author: samsonov
> Date: Tue Mar  4 07:12:25 2014
> New Revision: 202845
>
> URL: http://llvm.org/viewvc/llvm-project?rev=202845&view=rev
> Log:
> [ASan] Speed up stack trace unwinding for stacks of size 2.

Hi Alexey,

It looks like this commit breaks a buildbot:

http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-debian-fast/builds/13083

******************** TEST 'AddressSanitizer32 ::
TestCases/double-free.cc' FAILED ********************
Script:
--
/home/llvmbb/llvm-build-dir/llvm-clang-lld-x86_64-debian-fast/llvm.obj/./bin/clang
--driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer
-fno-omit-frame-pointer -fno-optimize-sibling-calls -g -m32 -O0
/home/llvmbb/llvm-build-dir/llvm-clang-lld-x86_64-debian-fast/llvm.src/projects/compiler-rt/test/asan/TestCases/double-free.cc
-o /home/llvmbb/llvm-build-dir/llvm-clang-lld-x86_64-debian-fast/llvm.obj/projects/compiler-rt/test/asan/32bitConfig/TestCases/Output/double-free.cc.tmp
2>&1
not /home/llvmbb/llvm-build-dir/llvm-clang-lld-x86_64-debian-fast/llvm.obj/projects/compiler-rt/test/asan/32bitConfig/TestCases/Output/double-free.cc.tmp
2>&1 | FileCheck
/home/llvmbb/llvm-build-dir/llvm-clang-lld-x86_64-debian-fast/llvm.src/projects/compiler-rt/test/asan/TestCases/double-free.cc
--check-prefix=CHECK --check-prefix=MALLOC-CTX
ASAN_OPTIONS=malloc_context_size=0:fast_unwind_on_malloc=0 not
/home/llvmbb/llvm-build-dir/llvm-clang-lld-x86_64-debian-fast/llvm.obj/projects/compiler-rt/test/asan/32bitConfig/TestCases/Output/double-free.cc.tmp
2>&1 | FileCheck
/home/llvmbb/llvm-build-dir/llvm-clang-lld-x86_64-debian-fast/llvm.src/projects/compiler-rt/test/asan/TestCases/double-free.cc
ASAN_OPTIONS=malloc_context_size=0:fast_unwind_on_malloc=1 not
/home/llvmbb/llvm-build-dir/llvm-clang-lld-x86_64-debian-fast/llvm.obj/projects/compiler-rt/test/asan/32bitConfig/TestCases/Output/double-free.cc.tmp
2>&1 | FileCheck
/home/llvmbb/llvm-build-dir/llvm-clang-lld-x86_64-debian-fast/llvm.src/projects/compiler-rt/test/asan/TestCases/double-free.cc
--
Exit Code: 1

Command Output (stderr):
--
/home/llvmbb/llvm-build-dir/llvm-clang-lld-x86_64-debian-fast/llvm.src/projects/compiler-rt/test/asan/TestCases/double-free.cc:18:12:
error: expected string not found in input
 // CHECK: #1 0x{{.*}} in main {{.*}}double-free.cc:[[@LINE-3]]
           ^
<stdin>:3:37: note: scanning from here
 #0 0x809f401 in __interceptor_free
/home/llvmbb/llvm-build-dir/llvm-clang-lld-x86_64-debian-fast/llvm.src/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:65
                                    ^
<stdin>:3:37: note: with expression "@LINE-3" equal to "15"
 #0 0x809f401 in __interceptor_free
/home/llvmbb/llvm-build-dir/llvm-clang-lld-x86_64-debian-fast/llvm.src/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:65
                                    ^
<stdin>:11:112: note: possible intended match here
 #8 0x80bc1e8 in main
/home/llvmbb/llvm-build-dir/llvm-clang-lld-x86_64-debian-fast/llvm.src/projects/compiler-rt/test/asan/TestCases/double-free.cc:15

                                        ^

--

********************

Could you please take a look?

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/