[PATCH] Add update target to ninja

Chandler Carruth chandlerc at gmail.com
Mon Mar 3 12:03:17 PST 2014


On Mon, Mar 3, 2014 at 11:58 AM, Justin Bogner <mail at justinbogner.com>wrote:

> Gautier DI FOLCO <gautier.difolco at gmail.com> writes:
> > I just added an update command to ninja, now we can do $ ninja update,
> > as we can do $ make update.
>
> Given that we recently removed 'make update' from the docs in r202430
> and the inherent limitations with having this be part of the build
> system (out of tree builds, git mirrors...), I'm not convinced we want
> to do this.
>

I'm strongly opposed to this. The build system should not mutate the source
tree. This is especially true for out-of-tree builds which are required
with our CMake setup IIRC.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140303/b10d2ffc/attachment.html>


More information about the llvm-commits mailing list