[PATCH] Remove out of date wording from LangRef

[Sean Silva]

On Wed, Feb 26, 2014 at 6:47 PM, Philip Reames <listmail at philipreames.com>wrote:

> This patch is a follow up to the thread "Stale type system documentation?"
> on llvmdev from a few weeks ago.
>
> Two important notes:
> - I don't have commit access and will need someone else to commit this
> patch
> - I couldn't figure out how to run the actual HTML generation step. I've
> tried to be careful, but you should check the change actually builds
> properly.
>

See docs/README.txt for how to generate the HTML (if that's not enough, let
me know and I will improve it to address whatever difficulties you ran
into). Off the top of my head, I at least see one issue which is that in
constructs like :ref:`Foo <Bar>`, you need to use backticks instead of
single quotes.


>
> Patch Comment:
> This patch removes confusing and out of date text from the LangRef. LLVM
> no longer performs structural uniquing on named types.  Most of the
> documentation was updated to reflect this, but this section got missed.  I
> attempted to replace the original wording with appropriate forward
> references, but it's debatable whether the section should be kept at all.


I think you have the direction of this patch backward. AFAIK the *current*
system uses structural uniquing.

-- Sean Silva


>
> Philip
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140301/0bd212a0/attachment.html>