[PATCH] Fix RWMutex to be thread-safe when pthread_rwlock is not available

JF Bastien jfb at google.com
Fri Feb 28 19:28:44 PST 2014


I agree with Mark's assessment: his patch is better than the current state
of things (silently saying a mutex was acquired when no such thing was
done, causing non-deterministic crashes); implementing RWMutex for a few
uses and only for a platform that doesn't have them is silly (when really
NaCl should have them at some point, but that doesn't remove the need for
this patch).

His patch makes it so that the next platform without RWMutex doesn't have
to debug this random crash. Overall lgtm.


On Fri, Feb 28, 2014 at 3:48 PM, Jan Voung <jvoung at chromium.org> wrote:

>
>   LGTM
>
> http://llvm-reviews.chandlerc.com/D2892
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140228/ff1a4c98/attachment.html>


More information about the llvm-commits mailing list