[PATCH] [lld][core] sectionGroup support.

Shankar Easwaran shankare at codeaurora.org
Fri Feb 28 09:00:32 PST 2014


On 2/28/2014 7:48 AM, Rafael EspĂ­ndola wrote:
> On 27 February 2014 23:37, Shankar Easwaram <shankarke at gmail.com> wrote:
>> This is a very good suggestion. But I am not sure on how to accomplish that as With lld each file is parsed in parallel. It might be useful to produce an error probably after atomizing them if the atoms in the group are different, also it would make sense to discard eh frame information as well for discarded sections.
> You cannot produce an error if they are different. That is perfectly
> legal. Consider for example linking two files compiled with different
> optimization options.
>
> With the parallel reading we would need to just record which files
> have which groups during the first pass. Deterministically pick one
> after we read the files, and then atomize the groups. This second
> atomization stage can also happen in parallel, even for groups in the
> same file since they are non overlapping. If this seems too
> complicated to implement now, it is always an improvement we can try
> afterwards.
>
> Cheers,
> Rafael
>
This is a very good suggestion. We could do this with running a pass I 
think, I will possibly create patches iteratively, adding one 
functionality over another.

Thanks

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation




More information about the llvm-commits mailing list