[PATCH] [lld][core] sectionGroup support.

Michael Spencer bigcheesegs at gmail.com
Thu Feb 27 16:37:55 PST 2014


On Thu, Feb 27, 2014 at 4:34 PM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
>> This is comdat, where the name does matter. The groups here aren't
>> influencing symbol resolution directly. The linker first removes
>> bar.o's g1. Then symbol resolution proceeds as normal. If they were
>> not comdat, this would be a multiple definition error (of g1, f1, f2,
>> and d1).
>
> So, can't we just error on non-comdat groups (error: no idea what to
> do with this)? What are they used for?
>
> Cheers,
> Rafael

Well, the spec still defines some semantics. It seems to me we need to
pass it through unmodified in -r mode. We also need to make correct
garbage collection choices. Other than that it doesn't matter. There's
no special symbol resolution handling.

- Michael Spencer




More information about the llvm-commits mailing list