[PATCH] A set of trivial changes to support sanitizers on FreeBSD
Alexey Samsonov
samsonov at google.com
Thu Feb 27 10:19:32 PST 2014
It's slightly confusing that we most of our _linux.cc file will now have code for FreeBSD file as well. But I can't think of a better name.
================
Comment at: lib/asan/asan_posix.cc:16
@@ -15,3 +15,3 @@
#include "sanitizer_common/sanitizer_platform.h"
-#if SANITIZER_LINUX || SANITIZER_MAC
+#if SANITIZER_LINUX || SANITIZER_FREEBSD || SANITIZER_MAC
----------------
Ed Maste wrote:
> Nit-picking, but how about putting these in alpha order? I would not be surprised to find someone adding support for other BSDs in the future, and it'll be easier to follow if the order is always consistent.
>
Just use SANITIZER_POSIX here.
================
Comment at: lib/sanitizer_common/sanitizer_posix.cc:16
@@ -15,3 +15,3 @@
#include "sanitizer_platform.h"
-#if SANITIZER_LINUX || SANITIZER_MAC
+#if SANITIZER_LINUX || SANITIZER_FREEBSD || SANITIZER_MAC
----------------
SANITIZER_POSIX here as well.
================
Comment at: lib/sanitizer_common/sanitizer_posix_libcdep.cc:17
@@ -16,3 +16,3 @@
-#if SANITIZER_LINUX || SANITIZER_MAC
+#if SANITIZER_LINUX || SANITIZER_FREEBSD || SANITIZER_MAC
#include "sanitizer_common.h"
----------------
SANITIZER_POSIX
http://llvm-reviews.chandlerc.com/D2897
More information about the llvm-commits
mailing list