[PATCH] Generic support for sub/super registers in AsmPrinter::EmitDwarfRegOp()

[Adrian Prantl]

On Feb 25, 2014, at 18:31, Eric Christopher <echristo at gmail.com> wrote:

> Hi Adrian,
> 
> Few comments on Patch #1:
> 
> The function comments from Patch #2 would be nice in this patch :)
> 
> +  if (Reg < 0) {
> +    if (!Indirect && !MLoc.isIndirect()) {
> +      // Walk up the super-register chain until we find a valid number.
> 
> Looks like this is designed to fail if we have Reg < 0 and indirect? I
> think? (Formatting is hard). At any rate an illuminating comment would
> be great.


There was actually no good reason to do this. I removed the check and instead emit 1-2 DW_OP_deref's.

> 
> +  else emitDwarfRegOp(*this, Reg);
> 
> Silly formatting nit, new line please.
> 

r202313.

thanks,
Adrian