[compiler-rt] r202296 - Emulate C99/C++11 __func__ for Visual C++.

[Reid Kleckner]

I always felt like __FUNCTION__'s string concatenation was a nice feature
that __func__ lacked.  Anyway, I don't feel that strongly.

I had to modify your change to get the flag in SANITIZER_COMMON_CFLAGS in
compiler-rt/CMakeLists.txt.  See r202303.  I only tested this by building
asan, since the asan test suite doesn't actually work on Windows yet.


On Wed, Feb 26, 2014 at 1:39 PM, Joerg Sonnenberger <joerg at britannica.bec.de
> wrote:

> On Wed, Feb 26, 2014 at 10:30:07PM +0100, Joerg Sonnenberger wrote:
> > On Wed, Feb 26, 2014 at 01:06:48PM -0800, Reid Kleckner wrote:
> > > I'd really rather not muck around in the implementors namespace like
> this.
> > >  If the compiler is actually clang-cl (which claims to be MSVC) or MSVC
> > > 2013 CTP, then __func__ will be available, and who knows what will
> happen.
> >
> > Can you try the attached patch, which uses a feature test? I am assuming
> > that C and C++ compiler support it both, if the former has it.
>
> Second version, apply it to the sanitizer build command as well.
>
> Joerg
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140226/9f5ffea7/attachment.html>