[llvm] r202188 - Debug info: Support variadic functions.

[Robinson, Paul]

> >> +    DIArray FnArgs = SP.getType().getTypeArray();
> >> +    if (FnArgs.getElement(FnArgs.getNumElements()-
> 1).isUnspecifiedParameter()) {
> >> +      DIE *Ellipsis = new DIE(dwarf::DW_TAG_unspecified_parameters);
> >> +      Children.push_back(Ellipsis);
> >> +    }
> >> +  }
> >> +
> >
> > This feels awkward here. Thoughts?
> 
> We have to insert it immediately after the formal parameters and before
> the variables. There does not seem to be a more appropriate place than
> this one.

Is this a gdb quirk?  DWARF says formal parameters and hopefully
unspecified_parameters have to be in order, but they don't have to
be adjacent.

If it's the most reasonable place regardless, that's fine.
--paulr