[lld] r202287 - [Mips] Exit from the class method as soon as possible.

Simon Atanasyan simon at atanasyan.com
Wed Feb 26 11:17:07 PST 2014


Author: atanasyan
Date: Wed Feb 26 13:17:07 2014
New Revision: 202287

URL: http://llvm.org/viewvc/llvm-project?rev=202287&view=rev
Log:
[Mips] Exit from the class method as soon as possible.

Modified:
    lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationHandler.cpp

Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationHandler.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationHandler.cpp?rev=202287&r1=202286&r2=202287&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationHandler.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationHandler.cpp Wed Feb 26 13:17:07 2014
@@ -163,6 +163,10 @@ void MipsTargetRelocationHandler::applyP
 error_code MipsTargetRelocationHandler::applyRelocation(
     ELFWriter &writer, llvm::FileOutputBuffer &buf, const lld::AtomLayout &atom,
     const Reference &ref) const {
+  if (ref.kindNamespace() != lld::Reference::KindNamespace::ELF)
+    return error_code::success();
+  assert(ref.kindArch() == Reference::KindArch::Mips);
+
   AtomLayout *gpAtom = _mipsTargetLayout.getGP();
   uint64_t gpAddr = gpAtom ? gpAtom->_virtualAddr : 0;
 
@@ -171,9 +175,6 @@ error_code MipsTargetRelocationHandler::
   uint64_t targetVAddress = writer.addressOfAtom(ref.target());
   uint64_t relocVAddress = atom._virtualAddr + ref.offsetInAtom();
 
-  if (ref.kindNamespace() != lld::Reference::KindNamespace::ELF)
-    return error_code::success();
-  assert(ref.kindArch() == Reference::KindArch::Mips);
   switch (ref.kindValue()) {
   case R_MIPS_NONE:
     break;





More information about the llvm-commits mailing list