[PATCH] Debug info: Support fragmented variables.

Eric Christopher echristo at gmail.com
Tue Feb 25 19:11:48 PST 2014


  Hi Adrian,

  This is a lot of great work, thanks!

  I think the first question is how this is going to interact with DIBuilder::createComplexVariable? I think it should just be a concatenation of the two things. It looks like you have it as an instead? In general, I think I like the idea that variable locations just have expressions attached to them. And lacking anything else I think dwarf expressions are just fine here.

  I've got more comments on the patch itself, but let's get this out of the way first.

  -eric

http://llvm-reviews.chandlerc.com/D2680



More information about the llvm-commits mailing list