[PATCH] ARMv8 IfConversion must skip narrow instructions that a) define CPSR and b) wouldn't affect CPSR in an IT block

[Weiming Zhao]

Hi Artyom,

Sorry for late reply. I read the code and LGTM. But I haven't applied the code and run some tests.
For the original bug, I am not fully convinced that it is due to emitting a wrong assembly mnemonic because I got run-time mismatch with integrated-as.

I think the functionality is for aarch32 only.

Thanks,
Weiming

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

-----Original Message-----
From: Tim Northover [mailto:t.p.northover at gmail.com] 
Sent: Tuesday, February 25, 2014 8:38 AM
To: Artyom Skrobov
Cc: llvm-commits; Weiming Zhao
Subject: Re: [PATCH] ARMv8 IfConversion must skip narrow instructions that a) define CPSR and b) wouldn't affect CPSR in an IT block

Hi Artyom,

> Therefore, when IfConversion applies the new ARMv8 restrictions, it 
> must not embed such an instruction into an IT block *whenever CPSR is 
> live after the instruction*.

Doesn't this apply on v7 as well? If so, that v8 function is the wrong place to apply the fix.

Cheers.

Tim.