AARCH64_BE load/store rules fix to conform to ARM ABI
Renato Golin
renato.golin at linaro.org
Tue Feb 25 09:10:02 PST 2014
On 25 February 2014 16:59, Albrecht Kadlec <akadlec at a-bix.com> wrote:
> there're a few misunderstandings:
I apologise.
> First, I'm not Christian (and he had a reviewer explicitly asking for those
> _related_ indentations, which brings up the question about global policy.)
This is a global policy, not sure where it is, though, or why people
accepted white space changes alongside functionality changes.
> If I try to preserve the indentation, using Requires<[IsLE]> per rule
> instead of the braces, all the lines that are now whitespace-diff-only will
> become real differences.
That's ok.
> BTW: did you know: "svn blame" also seems to accept "-x -w" to do the right
> thing for whitespaces.
That's only a small part of the problem. Rebase and revert are
actually a lot more complicated.
Sorry about that, I agree we shouldn't dwell further, please continue
with the review.
cheers,
--renato
More information about the llvm-commits
mailing list