[compiler-rt] r201916 - Revert "Replace __FUNCTION__ with __func__, the latter being standard C99/C++11."

Joerg Sonnenberger joerg at britannica.bec.de
Mon Feb 24 02:21:34 PST 2014


On Sat, Feb 22, 2014 at 03:07:10PM -0800, Richard Smith wrote:
> I don't think this is clear at all. This feature is not in C++98, and we're
> not allowing C++11 features yet.

Neither is __FUNCTION__.

> Even when we do, we only intend to allow
> C++11 features that are supported by all of our supported compilers, and
> this is not such a feature. Why should this be treated as a special case?

The choice is between a completely non-standard feature with strange
semantics and a standard feature that can be emulated easily on the
one compiler still not supporting a 15 year old spec. Attached is a
patch that should work for MSVC, but I can't test it.

Joerg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: func.diff
Type: text/x-diff
Size: 505 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140224/7e2eccb4/attachment.diff>


More information about the llvm-commits mailing list