[llvm] r201937 - Move get[S|U]LEB128Size() to LEB128.h.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Sat Feb 22 08:38:43 PST 2014


On 22 February 2014 10:51, Logan Chien <tzuhsiang.chien at gmail.com> wrote:
> Hi Rafael,
>
> I have changed them to non-inline function in r201939.

Thanks.

> I have checked the size of these function on x86_64.  It seems that the size
> impact are minor.  These function only needs 148 bytes and libLLVMSupport.a
> has 660379 in its text segment (i.e. the percentage is 0.02224%.)
>
> IMO, I would prefer to put them with encodeSLEB128() because I feel that it
> is a more straightforward for the developer to include LEB128.h for
> getSLEB128Size() in comparison with some MC layer header.

OK.

Cheers,
Rafael



More information about the llvm-commits mailing list