[llvm] r201921 - Use relative rpath so that the installation and build dirs are relocatable.

[Tobias Grosser]

On 02/22/2014 02:47 PM, Rafael Espíndola wrote:
>>> Does it work when building with configure?
>>
>>
>> No, with configure it seems no rpath is set and I need to explicitly set
>> LD_LIBRARY_PATH. The cmake behaviour now matches the autoconf behaviour. I
>> earlier cmake behaviour was more convenient, but if there are reasons to go
>> with the autoconf behaviour we can probably do this.
>> In case this is necessary, I can change the buildcommands and ask Galina to
>> restart the buildbots on Monday.
>
> I guess you can say the change was intentional then. In general it
> seems a bad (but admittedly convenient at times) to bake information
> about the build setup in the binaries. What I have done is change the
> logic just in polly to record where out of build-dir libraries are
> found.
>
> It is up to you if you want to keep that in polly or you want to
> switch to using LD_LIBRARY_PATH.

Thanks for looking into this so quickly. The buildbots are green again.

You are probably right, not hard-coding the library path is the cleaner 
approach. On the other side, I am tempted by the convenience the -rpath 
provides especially when working with different versions of polly and 
libisl. As I did not hear any packager complaining about the -rpath, I 
am tempted to leave it as it is with the comfort of having a patch in 
the git history that can change this if needed at some point.

Cheers,
Tobias