[llvm] r201811 - [Support] Correctly handle zero length inputs to UTF conversion functions on Windows.

[Rafael Espíndola]

On 20 February 2014 19:46, Gao, Yunzhong
<yunzhong_gao at playstation.sony.com> wrote:
> Hi Rafael,
>
> With this patch, UTF8ToUTF16 and UTF16ToUTF8 will convert an empty string back to an empty string instead of returning
> an error, which seems like a reasonable thing to do.

I agree.

> I do have a script that demonstrates the problem, but I am not sure whether it is possible to convert it into a regression test
> case (Any advice on this?). Without Mike's patch, the compiler will issue an "Parameter is incorrect" error. The same script
> worked with 3.3 but not with current trunk or 3.4.

Good question. I guess it depends on how good the quoting support is in lit.

Cheers,
Rafael