patch: simplify getUnderlyingObjectsForInstr

[Hal Finkel]

----- Original Message -----
> From: "Nick Lewycky" <nlewycky at google.com>
> To: "Commit Messages and Patches for LLVM" <llvm-commits at cs.uiuc.edu>
> Sent: Wednesday, February 19, 2014 11:03:04 PM
> Subject: patch: simplify getUnderlyingObjectsForInstr
> 
> 
> 
> getUnderlyingObjects (the CodeGen one, not to be confused with
> llvm::GetUnderlyingObjects the IR one) never puts any
> PseudoSourceValue's in its objects list, except in the case where
> it's given one as its starting Value in which case it only puts that
> one in and returns.
> 
> 
> 
> Thus we don't need to test for PSV's every iteration through the
> loop, and can simplify away local variable MayAlias. Remove one call
> to Objects.clear() as all callers call with an empty
> UnderlyingObjectsVector.
> 
> 
> I claim there's no functionality change in this patch. All tests
> still pass. Convinced?

LGTM.

 -Hal

> 
> 
> Nick
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory