[PATCH] including LLVM headers from ObjC++

Graham Lee graham at iamleeg.com
Wed Feb 19 11:53:04 PST 2014


Hi Tobias,

thanks! Here’s my commit message, I’ve tried to make sure it follows the style I see in svn.

Cheers,
Graham.

Change parameter names exposed in headers to avoid collisions with Objective-C++ keywords.

Fix PR15079.

On 19 Feb 2014, at 18:15, Tobias Grosser <tobias at grosser.es> wrote:

> On 02/19/2014 12:07 PM, Graham Lee wrote:
>> This patch addresses 15079: http://llvm.org/bugs/show_bug.cgi?id=15079
> 
> Hi Graham,
> 
> it seems unfortunate that we need to change our code to work around ObjC++ using very common non-reserved names, but as only three renames are required and the names you have choosen look sensible, just doing the renames is probably fine.
> 
> I wonder if you could use the information from the bug report to write
> a self-explanatory commit message. I can then commit the patch for you.
> 
> Cheers,
> Tobias
> 
> 






More information about the llvm-commits mailing list